media: coda: Use platform_get_irq() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 11 Jan 2022 00:23:14 +0000 (01:23 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 28 Jan 2022 12:16:00 +0000 (13:16 +0100)
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/coda/imx-vdoa.c

index 00643f37b3e6fff15db0d33cf7185492f6b80471..c70871bae193388df86dccd2c93aa908c5cdd8bd 100644 (file)
@@ -284,7 +284,6 @@ EXPORT_SYMBOL(vdoa_context_configure);
 static int vdoa_probe(struct platform_device *pdev)
 {
        struct vdoa_data *vdoa;
-       struct resource *res;
        int ret;
 
        ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
@@ -309,10 +308,10 @@ static int vdoa_probe(struct platform_device *pdev)
        if (IS_ERR(vdoa->regs))
                return PTR_ERR(vdoa->regs);
 
-       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!res)
-               return -EINVAL;
-       ret = devm_request_threaded_irq(&pdev->dev, res->start, NULL,
+       ret = platform_get_irq(pdev, 0);
+       if (ret < 0)
+               return ret;
+       ret = devm_request_threaded_irq(&pdev->dev, ret, NULL,
                                        vdoa_irq_handler, IRQF_ONESHOT,
                                        "vdoa", vdoa);
        if (ret < 0) {