- Add a "#error Unsupported target architecture." where needed. A chain of

  platform dependent ifdefs is useless if it does not include an error like
  this. You will end up searching for the failure in all the wrong places.
Review URL: http://codereview.chromium.org/150026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/codegen.h b/src/codegen.h
index fa4a628..243d87c 100644 (file)
--- a/src/codegen.h
+++ b/src/codegen.h
@@ -77,6 +77,8 @@ enum OverwriteMode { NO_OVERWRITE, OVERWRITE_LEFT, OVERWRITE_RIGHT };
 #include "x64/codegen-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/codegen-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 #include "register-allocator.h"

diff --git a/src/execution.cc b/src/execution.cc
index fa3c2ec..adc1872 100644 (file)
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -38,6 +38,8 @@
 #include "x64/simulator-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/simulator-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 #include "debug.h"

diff --git a/src/frames-inl.h b/src/frames-inl.h
index 0e2adb9..b04cf50 100644 (file)
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -36,6 +36,8 @@
 #include "x64/frames-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/frames-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 namespace v8 {

diff --git a/src/jsregexp.cc b/src/jsregexp.cc
index 7b294ec..879f671 100644 (file)
--- a/src/jsregexp.cc
+++ b/src/jsregexp.cc
@@ -51,6 +51,8 @@
 #include "x64/regexp-macro-assembler-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/regexp-macro-assembler-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 #include "interpreter-irregexp.h"

diff --git a/src/macro-assembler.h b/src/macro-assembler.h
index 116381b..983802e 100644 (file)
--- a/src/macro-assembler.h
+++ b/src/macro-assembler.h
@@ -47,6 +47,8 @@
 #include "arm/assembler-arm-inl.h"
 #include "code.h"  // must be after assembler_*.h
 #include "arm/macro-assembler-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 #endif  // V8_MACRO_ASSEMBLER_H_

diff --git a/src/platform-macos.cc b/src/platform-macos.cc
index 5a0eae2..f5b6458 100644 (file)
--- a/src/platform-macos.cc
+++ b/src/platform-macos.cc
@@ -507,7 +507,7 @@ static void ProfilerSignalHandler(int signal, siginfo_t* info, void* context) {
 #endif  // __DARWIN_UNIX03
 #else
 #error Unsupported Mac OS X host architecture.
-#endif  // V8_TARGET_ARCH_IA32
+#endif  // V8_HOST_ARCH_IA32
   }
 
   // We always sample the VM state.

diff --git a/src/virtual-frame.h b/src/virtual-frame.h
index 293f9e5..0bf0ca2 100644 (file)
--- a/src/virtual-frame.h
+++ b/src/virtual-frame.h
@@ -37,6 +37,8 @@
 #include "x64/virtual-frame-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/virtual-frame-arm.h"
+#else
+#error Unsupported target architecture.
 #endif
 
 #endif  // V8_VIRTUAL_FRAME_H_