net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()
authorJason Yan <yanaijie@huawei.com>
Wed, 6 May 2020 06:16:30 +0000 (14:16 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 May 2020 20:57:30 +0000 (13:57 -0700)
Fix the following coccicheck warning:

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded
variable: "err". Return "0" on line 1252

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

index 8a5ea25..216e6b2 100644 (file)
@@ -1235,7 +1235,6 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
        struct mlx4_en_priv *priv = netdev_priv(dev);
        u32 n = mlx4_en_get_rxfh_indir_size(dev);
        u32 i, rss_rings;
-       int err = 0;
 
        rss_rings = priv->prof->rss_rings ?: n;
        rss_rings = rounddown_pow_of_two(rss_rings);
@@ -1249,7 +1248,7 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
                memcpy(key, priv->rss_key, MLX4_EN_RSS_KEY_SIZE);
        if (hfunc)
                *hfunc = priv->rss_hash_fn;
-       return err;
+       return 0;
 }
 
 static int mlx4_en_set_rxfh(struct net_device *dev, const u32 *ring_index,