accel/habanalabs: fix bug in free scratchpad memory
authorMoti Haimovski <mhaimovski@habana.ai>
Mon, 10 Apr 2023 06:31:16 +0000 (09:31 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 5 Jun 2023 12:31:33 +0000 (15:31 +0300)
This commit fixes a bug in Gaudi2 when freeing the scratchpad memory
in case software init fails.

Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index 6f05aa2..acc304e 100644 (file)
@@ -3630,8 +3630,8 @@ static int gaudi2_sw_init(struct hl_device *hdev)
 special_blocks_free:
        gaudi2_special_blocks_iterator_free(hdev);
 free_scratchpad_mem:
-       hl_asic_dma_pool_free(hdev, gaudi2->scratchpad_kernel_address,
-                               gaudi2->scratchpad_bus_address);
+       hl_asic_dma_free_coherent(hdev, PAGE_SIZE, gaudi2->scratchpad_kernel_address,
+                                 gaudi2->scratchpad_bus_address);
 free_virt_msix_db_mem:
        hl_cpu_accessible_dma_pool_free(hdev, prop->pmmu.page_size, gaudi2->virt_msix_db_cpu_addr);
 free_cpu_accessible_dma_pool: