Check the GLib.Type of both elements for AbstractFieldDetails.equal()
authorTravis Reitter <travis.reitter@collabora.co.uk>
Fri, 21 Oct 2011 22:54:07 +0000 (15:54 -0700)
committerTravis Reitter <travis.reitter@collabora.co.uk>
Mon, 24 Oct 2011 18:39:23 +0000 (11:39 -0700)
This simplifies the code for overridden equal() functions.

folks/abstract-field-details.vala

index f54670a..960406a 100644 (file)
@@ -254,7 +254,9 @@ public abstract class Folks.AbstractFieldDetails<T> : Object
    */
   public virtual bool equal (AbstractFieldDetails<T> that)
     {
-      return this.values_equal<T> (that) && this.parameters_equal<T> (that);
+      return (this.get_type () == that.get_type ()) &&
+        this.values_equal<T> (that) &&
+        this.parameters_equal<T> (that);
     }
 
   /**