xhci: omit mem read just after allocation of trb
authorOliver Neukum <oneukum@suse.com>
Thu, 17 Feb 2022 13:35:49 +0000 (14:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Feb 2022 10:19:21 +0000 (11:19 +0100)
This has been allocated just a few lines earlier with a
zalloc(). The value is known and "|=" is a waste of memory
cycles.

Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20220217133549.27961-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-mem.c

index f8c2b6c..cb70d0b 100644 (file)
@@ -57,7 +57,7 @@ static struct xhci_segment *xhci_segment_alloc(struct xhci_hcd *xhci,
        /* If the cycle state is 0, set the cycle bit to 1 for all the TRBs */
        if (cycle_state == 0) {
                for (i = 0; i < TRBS_PER_SEGMENT; i++)
-                       seg->trbs[i].link.control |= cpu_to_le32(TRB_CYCLE);
+                       seg->trbs[i].link.control = cpu_to_le32(TRB_CYCLE);
        }
        seg->dma = dma;
        seg->next = NULL;