drm/amd/pm: use vbios carried pptable for all SMU13.0.7 SKUs
authorEvan Quan <evan.quan@amd.com>
Tue, 23 Aug 2022 08:07:18 +0000 (16:07 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 29 Aug 2022 21:59:29 +0000 (17:59 -0400)
For those SMU13.0.7 unsecure SKUs, the vbios carried pptable is ready to go.
Use that one instead of hardcoded softpptable.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Kenneth Feng <kenneth.feng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

index 1016d1c..fcf24c5 100644 (file)
@@ -400,11 +400,27 @@ static int smu_v13_0_7_append_powerplay_table(struct smu_context *smu)
        return 0;
 }
 
+static int smu_v13_0_7_get_pptable_from_pmfw(struct smu_context *smu,
+                                            void **table,
+                                            uint32_t *size)
+{
+       struct smu_table_context *smu_table = &smu->smu_table;
+       void *combo_pptable = smu_table->combo_pptable;
+       int ret = 0;
+
+       ret = smu_cmn_get_combo_pptable(smu);
+       if (ret)
+               return ret;
+
+       *table = combo_pptable;
+       *size = sizeof(struct smu_13_0_7_powerplay_table);
+
+       return 0;
+}
 
 static int smu_v13_0_7_setup_pptable(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
-       void *combo_pptable = smu_table->combo_pptable;
        struct amdgpu_device *adev = smu->adev;
        int ret = 0;
 
@@ -413,18 +429,11 @@ static int smu_v13_0_7_setup_pptable(struct smu_context *smu)
         * be used directly by driver. To get the raw pptable, we need to
         * rely on the combo pptable(and its revelant SMU message).
         */
-       if (adev->scpm_enabled) {
-               ret = smu_cmn_get_combo_pptable(smu);
-               if (ret)
-                       return ret;
-
-               smu->smu_table.power_play_table = combo_pptable;
-               smu->smu_table.power_play_table_size = sizeof(struct smu_13_0_7_powerplay_table);
-       } else {
-               ret = smu_v13_0_setup_pptable(smu);
-               if (ret)
-                       return ret;
-       }
+       ret = smu_v13_0_7_get_pptable_from_pmfw(smu,
+                                               &smu_table->power_play_table,
+                                               &smu_table->power_play_table_size);
+       if (ret)
+               return ret;
 
        ret = smu_v13_0_7_store_powerplay_table(smu);
        if (ret)