scsi: libcxgbi: remove unused function to stop warning
authorAustin Kim <austindh.kim@gmail.com>
Tue, 24 Sep 2019 09:37:16 +0000 (18:37 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Oct 2019 03:27:04 +0000 (23:27 -0400)
Since 'commit fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")' was
introduced, there is no call to csk_print_port() and csk_print_ip() is
made.

Hence kernel build with clang complains below message:
   drivers/scsi/cxgbi/libcxgbi.c:2287:19: warning: unused function 'csk_print_port' [-Wunused-function]
   static inline int csk_print_port(struct cxgbi_sock *csk, char *buf)
                          ^
   drivers/scsi/cxgbi/libcxgbi.c:2298:19: warning: unused function 'csk_print_ip' [-Wunused-function]
   static inline int csk_print_ip(struct cxgbi_sock *csk, char *buf)
                        ^

Remove csk_print_port() and csk_print_ip() to stop warning.

Link: https://lore.kernel.org/r/20190924093716.GA78230@LGEARND20B15
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxgbi/libcxgbi.c

index 3e17af8..0d044c1 100644 (file)
@@ -2284,34 +2284,6 @@ int cxgbi_set_conn_param(struct iscsi_cls_conn *cls_conn,
 }
 EXPORT_SYMBOL_GPL(cxgbi_set_conn_param);
 
-static inline int csk_print_port(struct cxgbi_sock *csk, char *buf)
-{
-       int len;
-
-       cxgbi_sock_get(csk);
-       len = sprintf(buf, "%hu\n", ntohs(csk->daddr.sin_port));
-       cxgbi_sock_put(csk);
-
-       return len;
-}
-
-static inline int csk_print_ip(struct cxgbi_sock *csk, char *buf)
-{
-       int len;
-
-       cxgbi_sock_get(csk);
-       if (csk->csk_family == AF_INET)
-               len = sprintf(buf, "%pI4",
-                             &csk->daddr.sin_addr.s_addr);
-       else
-               len = sprintf(buf, "%pI6",
-                             &csk->daddr6.sin6_addr);
-
-       cxgbi_sock_put(csk);
-
-       return len;
-}
-
 int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param,
                       char *buf)
 {