Phase 2 of #6805.
Build warning counts : 1521 -> 1424 (Reduce 97)
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
/// <since_tizen> 3 </since_tizen>
public class Renderer : Animatable
{
- private Geometry CurrentGeometry = null;
- private Shader CurrentShader = null;
+ private Geometry CurrentGeometry;
+ private Shader CurrentShader;
/// <summary>
/// Create an instance of Renderer.
#region Private
- private string resourceUrl = null;
- private int repeatCnt = 0;
+ private string resourceUrl;
+ private int repeatCnt;
private RepeatModes repeatMode = RepeatModes.Restart;
private int minimumFrame = -1, maximumFrame = -1;
- private string minimumFrameMarker = null;
- private string maximumFrameMarker = null;
+ private string minimumFrameMarker;
+ private string maximumFrameMarker;
private minMaxSetTypes isMinMaxFrameSet = minMaxSetTypes.NotSetByUser;
private int innerCurrentFrame = -1;
private EndActions innerEndAction = EndActions.Cancel;
ImageVisualProperty.FastTrackUploading,
};
internal PropertyMap cachedImagePropertyMap;
- internal bool imagePropertyUpdatedFlag = false;
+ internal bool imagePropertyUpdatedFlag;
- private bool imagePropertyUpdateProcessAttachedFlag = false;
+ private bool imagePropertyUpdateProcessAttachedFlag;
private Rectangle _border;
// Development Guide : Please make ensure that these 5 values are matched with current image.
private string _alphaMaskUrl = "";
private int _desired_width = -1;
private int _desired_height = -1;
- private bool _fastTrackUploading = false;
+ private bool _fastTrackUploading;
private TriggerableSelector<string> resourceUrlSelector;
private TriggerableSelector<Rectangle> borderSelector;
NotifyPropertyChanged();
}
}
- private bool adjustViewSize = false;
+ private bool adjustViewSize;
/// <summary>
/// ImageView PlaceHolderUrl, type string.
private VisualEventSignalCallbackType visualEventSignalCallback;
private EventHandler<VisualEventSignalArgs> visualEventSignalHandler;
- static private int dynamicPropertyCallbackId = 0;
+ static private int dynamicPropertyCallbackId;
//static private Dictionary<int, DynamicPropertyCallbackType> dynamicPropertyCallbacks = new Dictionary<int, DynamicPropertyCallbackType>();
static private ConcurrentDictionary<int, WeakReference<LottieAnimationView>> weakReferencesOfLottie = new ConcurrentDictionary<int, WeakReference<LottieAnimationView>>();
{
static private string defaultStyleName = "Tizen.NUI.BaseComponents.TextEditor";
static private string defaultFontFamily = "TizenSans";
- private string textEditorTextSid = null;
- private string textEditorPlaceHolderTextSid = null;
- private InputMethodContext inputMethodContext = null;
+ private string textEditorTextSid;
+ private string textEditorPlaceHolderTextSid;
+ private InputMethodContext inputMethodContext;
private string fontFamily = defaultFontFamily;
private float fontSizeScale = 1.0f;
- private bool hasSystemLanguageChanged = false;
- private bool hasSystemFontSizeChanged = false;
- private bool hasSystemFontTypeChanged = false;
- private bool isSettingTextInCSharp = false;
-
- private Color internalPlaceholderTextColor = null;
- private Vector4 internalPrimaryCursorColor = null;
- private Vector4 internalSecondaryCursorColor = null;
- private Vector4 internalSelectionHighlightColor = null;
- private Vector4 internalInputColor = null;
- private Vector4 internalTextColor = null;
- private Color internalGrabHandleColor = null;
+ private bool hasSystemLanguageChanged;
+ private bool hasSystemFontSizeChanged;
+ private bool hasSystemFontTypeChanged;
+ private bool isSettingTextInCSharp;
+
+ private Color internalPlaceholderTextColor;
+ private Vector4 internalPrimaryCursorColor;
+ private Vector4 internalSecondaryCursorColor;
+ private Vector4 internalSelectionHighlightColor;
+ private Vector4 internalInputColor;
+ private Vector4 internalTextColor;
+ private Color internalGrabHandleColor;
static TextEditor()
{
static private string defaultStyleName = "Tizen.NUI.BaseComponents.TextField";
static private string defaultFontFamily = "TizenSans";
- private string textFieldTextSid = null;
- private string textFieldPlaceHolderTextSid = null;
- private string textFieldPlaceHolderTextFocusedSid = null;
- private InputMethodContext inputMethodCotext = null;
+ private string textFieldTextSid;
+ private string textFieldPlaceHolderTextSid;
+ private string textFieldPlaceHolderTextFocusedSid;
+ private InputMethodContext inputMethodCotext;
private string fontFamily = defaultFontFamily;
private float fontSizeScale = 1.0f;
- private bool hasSystemLanguageChanged = false;
- private bool hasSystemFontSizeChanged = false;
- private bool hasSystemFontTypeChanged = false;
- private bool isSettingTextInCSharp = false;
-
- private Vector4 internalPlaceholderTextColor = null;
- private Vector4 internalPrimaryCursorColor = null;
- private Vector4 internalSecondaryCursorColor = null;
- private Vector4 internalSelectionHighlightColor = null;
- private Vector4 internalInputColor = null;
- private Color internalTextColor = null;
- private Color internalGrabHandleColor = null;
+ private bool hasSystemLanguageChanged;
+ private bool hasSystemFontSizeChanged;
+ private bool hasSystemFontTypeChanged;
+ private bool isSettingTextInCSharp;
+
+ private Vector4 internalPlaceholderTextColor;
+ private Vector4 internalPrimaryCursorColor;
+ private Vector4 internalSecondaryCursorColor;
+ private Vector4 internalSelectionHighlightColor;
+ private Vector4 internalInputColor;
+ private Color internalTextColor;
+ private Color internalGrabHandleColor;
static TextField()
static private string defaultStyleName = "Tizen.NUI.BaseComponents.TextLabel";
static private string defaultFontFamily = "BreezeSans";
- private string textLabelSid = null;
+ private string textLabelSid;
private TextLabelSelectorData selectorData;
private string fontFamily = defaultFontFamily;
private float fontSizeScale = 1.0f;
private bool textIsEmpty = true;
- private bool hasSystemLanguageChanged = false;
- private bool hasSystemFontSizeChanged = false;
- private bool hasSystemFontTypeChanged = false;
+ private bool hasSystemLanguageChanged;
+ private bool hasSystemFontSizeChanged;
+ private bool hasSystemFontTypeChanged;
private Color internalTextColor;
private Color internalAnchorColor;
private static HashSet<BindableProperty> positionPropertyGroup = new HashSet<BindableProperty>();
private static HashSet<BindableProperty> sizePropertyGroup = new HashSet<BindableProperty>();
private static HashSet<BindableProperty> scalePropertyGroup = new HashSet<BindableProperty>();
- private static bool defaultGrabTouchAfterLeave = false;
- private static bool defaultAllowOnlyOwnTouch = false;
+ private static bool defaultGrabTouchAfterLeave;
+ private static bool defaultAllowOnlyOwnTouch;
internal BackgroundExtraData backgroundExtraData;
private int widthPolicy = LayoutParamPolicies.WrapContent;
private LayoutExtraData layoutExtraData;
private ThemeData themeData;
private Dictionary<Type, object> attached;
- private bool isThemeChanged = false;
+ private bool isThemeChanged;
// Collection of image-sensitive properties, and need to update C# side cache value.
private static readonly List<int> cachedNUIViewBackgroundImagePropertyKeyList = new List<int> {
ImageVisualProperty.URL,
ImageVisualProperty.SynchronousLoading,
};
- private string backgroundImageUrl = null;
- private bool backgroundImageSynchronousLoading = false;
+ private string backgroundImageUrl;
+ private bool backgroundImageSynchronousLoading;
// List of constraints
- private Constraint widthConstraint = null;
- private Constraint heightConstraint = null;
-
- private Size2D internalMaximumSize = null;
- private Size2D internalMinimumSize = null;
- private Extents internalMargin = null;
- private Extents internalPadding = null;
- private Vector3 internalSizeModeFactor = null;
- private Vector2 internalCellIndex = null;
- private Color internalBackgroundColor = null;
- private Color internalColor = null;
- private Position internalPivotPoint = null;
- private Position internalPosition = null;
- private Position2D internalPosition2D = null;
- private Vector3 internalScale = null;
- private Size internalSize = null;
- private Size2D internalSize2D = null;
- private int layoutCount = 0;
+ private Constraint widthConstraint;
+ private Constraint heightConstraint;
+
+ private float userSizeWidth;
+ private float userSizeHeight;
+
+ private Size2D internalMaximumSize;
+ private Size2D internalMinimumSize;
+ private Extents internalMargin;
+ private Extents internalPadding;
+ private Vector3 internalSizeModeFactor;
+ private Vector2 internalCellIndex;
+ private Color internalBackgroundColor;
+ private Color internalColor;
+ private Position internalPivotPoint;
+ private Position internalPosition;
+ private Position2D internalPosition2D;
+ private Vector3 internalScale;
+ private Size internalSize;
+ private Size2D internalSize2D;
+ private int layoutCount;
private ControlState propagatableControlStates = ControlState.All;
private string internalName = string.Empty;
- private Position internalCurrentParentOrigin = null;
- private Position internalCurrentAnchorPoint = null;
- private Vector3 internalTargetSize = null;
- private Size2D internalCurrentSize = null;
- private Position internalCurrentPosition = null;
- private Vector3 internalCurrentWorldPosition = null;
- private Vector3 internalCurrentScale = null;
- private Vector3 internalCurrentWorldScale = null;
- private Vector4 internalCurrentColor = null;
- private Vector4 internalCurrentWorldColor = null;
- private Vector2 internalCurrentScreenPosition = null;
-
- private static int aliveCount = 0;
+ private Position internalCurrentParentOrigin;
+ private Position internalCurrentAnchorPoint;
+ private Vector3 internalTargetSize;
+ private Size2D internalCurrentSize;
+ private Position internalCurrentPosition;
+ private Vector3 internalCurrentWorldPosition;
+ private Vector3 internalCurrentScale;
+ private Vector3 internalCurrentWorldScale;
+ private Vector4 internalCurrentColor;
+ private Vector4 internalCurrentWorldColor;
+ private Vector2 internalCurrentScreenPosition;
+
+ /// <summary>
+ /// Indicates that this View should listen Touch event to handle its ControlState.
+ /// </summary>
+ private bool enableControlState;
+
+ private static int aliveCount;
static View()
{
/// <summary>
/// Start position in stored text.
/// </summary>
- public int StartOffset { get; set; } = 0;
+ public int StartOffset { get; set; }
/// <summary>
/// End position in stored text.
/// </summary>
- public int EndOffset { get; set; } = 0;
+ public int EndOffset { get; set; }
/// <summary>
/// Text content in stored text.
/// <since_tizen> 3 </since_tizen>
public partial class View
{
- private float userSizeWidth = 0.0f;
- private float userSizeHeight = 0.0f;
-
/// <summary>
/// StyleNameProperty (DALi json)
/// </summary>
private delegate void LayoutDirectionChangedEventCallbackType(IntPtr data, ViewLayoutDirectionType type);
// List of dispatch Event
- private PanGestureDetector panGestureDetector = null;
- private LongPressGestureDetector longGestureDetector = null;
- private PinchGestureDetector pinchGestureDetector = null;
- private TapGestureDetector tapGestureDetector = null;
- private RotationGestureDetector rotationGestureDetector = null;
- private int configGestureCount = 0;
+ private PanGestureDetector panGestureDetector;
+ private LongPressGestureDetector longGestureDetector;
+ private PinchGestureDetector pinchGestureDetector;
+ private TapGestureDetector tapGestureDetector;
+ private RotationGestureDetector rotationGestureDetector;
+ private int configGestureCount;
private bool dispatchTouchEvents = true;
private bool dispatchParentTouchEvents = true;
private bool dispatchHoverEvents = true;
}
}
- /// <summary>
- /// Indicates that this View should listen Touch event to handle its ControlState.
- /// </summary>
- private bool enableControlState = false;
-
private int LeftFocusableViewId
{
get
internalCurrentScreenPosition?.Dispose();
internalCurrentScreenPosition = null;
+ backgroundExtraData?.Dispose();
+ backgroundExtraData = null;
+ layoutExtraData?.Dispose();
+ layoutExtraData = null;
+
if (visualContainers != null)
{
foreach (var visualContainer in visualContainers)
public partial class View
{
#region Internal and Private
- private List<Tizen.NUI.Visuals.VisualObjectsContainer> visualContainers = null;
+ private List<Tizen.NUI.Visuals.VisualObjectsContainer> visualContainers;
/// <summary>
/// Range of visual for the container.
/// <since_tizen> 3 </since_tizen>
public class VisualView : CustomView
{
- private Dictionary<int, string> visualNameDictionary = null;
- private Dictionary<int, VisualBase> visualDictionary = null;
- private Dictionary<int, PropertyMap> tranformDictionary = null;
- private PropertyArray animateArray = null;
+ private Dictionary<int, string> visualNameDictionary;
+ private Dictionary<int, VisualBase> visualDictionary;
+ private Dictionary<int, PropertyMap> tranformDictionary;
+ private PropertyArray animateArray;
/// <summary>
/// Constructor.
}
internal delegate void ColorChangedCallback(float r, float g, float b, float a);
- private ColorChangedCallback callback = null;
+ private ColorChangedCallback callback;
/// <summary>
/// The red component.
[EditorBrowsable(EditorBrowsableState.Never)]
public partial class Renderable : Animatable
{
- private Geometry geometry = null;
- private Shader shader = null;
+ private Geometry geometry;
+ private Shader shader;
/// <summary>
/// Create an instance of Renderable without Geometry or Shader.