pNFS/flexfiles: Clean up redundant calls to pnfs_put_lseg()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Thu, 18 Jun 2020 17:22:04 +0000 (13:22 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 13 Jul 2020 03:49:55 +0000 (23:49 -0400)
Both nfs_pageio_reset_read_mds() and nfs_pageio_reset_write_mds()
do call pnfs_generic_pg_cleanup() for us.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/flexfilelayout/flexfilelayout.c

index de03e44..b3ec12e 100644 (file)
@@ -844,8 +844,7 @@ retry:
        if (!ds) {
                if (!ff_layout_no_fallback_to_mds(pgio->pg_lseg))
                        goto out_mds;
-               pnfs_put_lseg(pgio->pg_lseg);
-               pgio->pg_lseg = NULL;
+               pnfs_generic_pg_cleanup(pgio);
                /* Sleep for 1 second before retrying */
                ssleep(1);
                goto retry;
@@ -871,8 +870,6 @@ out_mds:
                        0, NFS4_MAX_UINT64, IOMODE_READ,
                        NFS_I(pgio->pg_inode)->layout,
                        pgio->pg_lseg);
-       pnfs_put_lseg(pgio->pg_lseg);
-       pgio->pg_lseg = NULL;
        pgio->pg_maxretrans = 0;
        nfs_pageio_reset_read_mds(pgio);
 }
@@ -916,8 +913,7 @@ retry:
                if (!ds) {
                        if (!ff_layout_no_fallback_to_mds(pgio->pg_lseg))
                                goto out_mds;
-                       pnfs_put_lseg(pgio->pg_lseg);
-                       pgio->pg_lseg = NULL;
+                       pnfs_generic_pg_cleanup(pgio);
                        /* Sleep for 1 second before retrying */
                        ssleep(1);
                        goto retry;
@@ -939,8 +935,6 @@ out_mds:
                        0, NFS4_MAX_UINT64, IOMODE_RW,
                        NFS_I(pgio->pg_inode)->layout,
                        pgio->pg_lseg);
-       pnfs_put_lseg(pgio->pg_lseg);
-       pgio->pg_lseg = NULL;
        pgio->pg_maxretrans = 0;
        nfs_pageio_reset_write_mds(pgio);
        pgio->pg_error = -EAGAIN;