fbdev/uvesafb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:36:08 +0000 (20:36 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:38 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Cc: Michal Januszewski <spock@gentoo.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-44-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/uvesafb.c

index f5ce8d6..e6ca543 100644 (file)
@@ -438,9 +438,7 @@ config FB_UVESA
        tristate "Userspace VESA VGA graphics support"
        depends on FB && CONNECTOR
        depends on !UML
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
        help
          This is the frame buffer driver for generic VBE 2.0 compliant
index df2574d..a1a6783 100644 (file)
@@ -1416,13 +1416,11 @@ static struct fb_ops uvesafb_ops = {
        .owner          = THIS_MODULE,
        .fb_open        = uvesafb_open,
        .fb_release     = uvesafb_release,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_setcolreg   = uvesafb_setcolreg,
        .fb_setcmap     = uvesafb_setcmap,
        .fb_pan_display = uvesafb_pan_display,
        .fb_blank       = uvesafb_blank,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
        .fb_check_var   = uvesafb_check_var,
        .fb_set_par     = uvesafb_set_par,
 };