net: diag: make udp_diag_destroy work for mapped addresses.
authorLorenzo Colitti <lorenzo@google.com>
Wed, 7 Sep 2016 04:38:35 +0000 (13:38 +0900)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Sep 2016 00:31:30 +0000 (17:31 -0700)
udp_diag_destroy does look up the IPv4 UDP hashtable for mapped
addresses, but it gets the IPv4 address to look up from the
beginning of the IPv6 address instead of the end.

Tested: https://android-review.googlesource.com/269874
Fixes: 5d77dca82839 ("net: diag: support SOCK_DESTROY for UDP sockets")
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_diag.c

index 8a9f6e5..58b79c0 100644 (file)
@@ -186,8 +186,8 @@ static int __udp_diag_destroy(struct sk_buff *in_skb,
                if (ipv6_addr_v4mapped((struct in6_addr *)req->id.idiag_dst) &&
                    ipv6_addr_v4mapped((struct in6_addr *)req->id.idiag_src))
                        sk = __udp4_lib_lookup(net,
-                                       req->id.idiag_dst[0], req->id.idiag_dport,
-                                       req->id.idiag_src[0], req->id.idiag_sport,
+                                       req->id.idiag_dst[3], req->id.idiag_dport,
+                                       req->id.idiag_src[3], req->id.idiag_sport,
                                        req->id.idiag_if, tbl, NULL);
 
                else