ftrace: sample: avoid open-coded 64-bit division
authorArnd Bergmann <arnd@arndb.de>
Mon, 30 Jan 2023 13:02:37 +0000 (14:02 +0100)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 7 Feb 2023 17:45:18 +0000 (12:45 -0500)
Calculating the average period requires a 64-bit division that leads
to a link failure on 32-bit architectures:

x86_64-linux-ld: samples/ftrace/ftrace-ops.o: in function `ftrace_ops_sample_init':
ftrace-ops.c:(.init.text+0x23b): undefined reference to `__udivdi3'

Use the div_u64() helper to do this instead. Since this is an init function that
is not called frequently, the runtime overhead is going to be acceptable.

Link: https://lore.kernel.org/linux-trace-kernel/20230130130246.247537-1-arnd@kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: b56c68f705ca ("ftrace: Add sample with custom ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
samples/ftrace/ftrace-ops.c

index 24deb51..0c8da87 100644 (file)
@@ -223,7 +223,7 @@ static int __init ftrace_ops_sample_init(void)
 
        pr_info("Attempted %u calls to %ps in %lluns (%lluns / call)\n",
                nr_function_calls, tracee_relevant,
-               period, period / nr_function_calls);
+               period, div_u64(period, nr_function_calls));
 
        if (persist)
                return 0;