swiotlb: move slot allocation explanation comment where it belongs
authorPetr Tesarik <petr.tesarik.ext@huawei.com>
Wed, 2 Aug 2023 16:30:34 +0000 (18:30 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 8 Aug 2023 17:29:06 +0000 (10:29 -0700)
Move the comment down in front of the loop that actually sets the list
member of struct io_tlb_slot to zero.

Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
Signed-off-by: Petr Tesarik <petr.tesarik.ext@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
kernel/dma/swiotlb.c

index d7eac84..50a0e9c 100644 (file)
@@ -1018,11 +1018,6 @@ static int swiotlb_area_find_slots(struct device *dev, struct io_tlb_pool *pool,
                        continue;
                }
 
-               /*
-                * If we find a slot that indicates we have 'nslots' number of
-                * contiguous buffers, we allocate the buffers from that slot
-                * and mark the entries as '0' indicating unavailable.
-                */
                if (!iommu_is_span_boundary(slot_index, nslots,
                                            nr_slots(tbl_dma_addr),
                                            max_slots)) {
@@ -1038,6 +1033,11 @@ not_found:
        return -1;
 
 found:
+       /*
+        * If we find a slot that indicates we have 'nslots' number of
+        * contiguous buffers, we allocate the buffers from that slot onwards
+        * and set the list of free entries to '0' indicating unavailable.
+        */
        for (i = slot_index; i < slot_index + nslots; i++) {
                pool->slots[i].list = 0;
                pool->slots[i].alloc_size = alloc_size - (offset +