Revert "power: regulator: Return success on attempt to disable an always-on regulator"
authorLokesh Vutla <lokeshvutla@ti.com>
Fri, 11 Jan 2019 09:45:50 +0000 (15:15 +0530)
committerSimon Glass <sjg@chromium.org>
Sat, 9 Feb 2019 19:50:22 +0000 (12:50 -0700)
This reverts commit e17e0ceb83538c015a50b965547f2f4d38f81c5d.

It is advised to return an error when trying to disable an always-on
regulator and let the consumer driver handle the error if needed.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
drivers/power/regulator/regulator-uclass.c

index 39e4627..4511625 100644 (file)
@@ -113,7 +113,7 @@ int regulator_set_enable(struct udevice *dev, bool enable)
 
        uc_pdata = dev_get_uclass_platdata(dev);
        if (!enable && uc_pdata->always_on)
-               return 0;
+               return -EACCES;
 
        return ops->set_enable(dev, enable);
 }