projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bf3577e
)
[NFC][OpenMP] Remove outdated comments about potential issues
author
Shilei Tian
<tianshilei1992@gmail.com>
Mon, 24 Aug 2020 01:21:06 +0000
(
01:21
+0000)
committer
Shilei Tian
<tianshilei1992@gmail.com>
Mon, 24 Aug 2020 01:21:06 +0000
(
01:21
+0000)
The issue mentioned has been fixed in D84996
openmp/libomptarget/src/omptarget.cpp
patch
|
blob
|
history
diff --git
a/openmp/libomptarget/src/omptarget.cpp
b/openmp/libomptarget/src/omptarget.cpp
index
aa4ab75
..
bc9287f
100644
(file)
--- a/
openmp/libomptarget/src/omptarget.cpp
+++ b/
openmp/libomptarget/src/omptarget.cpp
@@
-953,8
+953,6
@@
int processDataBefore(int64_t DeviceId, void *HostPtr, int32_t ArgNum,
/// Process data after launching the kernel, including transferring data back to
/// host if needed and deallocating target memory of (first-)private variables.
-/// FIXME: This function has correctness issue that target memory might be
-/// deallocated when they're being used.
int processDataAfter(int64_t DeviceId, void *HostPtr, int32_t ArgNum,
void **ArgBases, void **Args, int64_t *ArgSizes,
int64_t *ArgTypes, void **ArgMappers,