soundwire: qcom: reinit broadcast completion

For some reason we never reinit the broadcast completion, there is a
danger that broadcast commands could be treated as completed by driver
from previous complete status.
Fix this by reinitializing the completion before sending a broadcast command.

Fixes: ddea6cf7b619 ("soundwire: qcom: update register read/write routine")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20221026110210.6575-2-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index b33d5db..8f1a1eb 100644 (file)
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -344,6 +344,9 @@ static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *swrm, u8 cmd_data,
        if (swrm_wait_for_wr_fifo_avail(swrm))
                return SDW_CMD_FAIL_OTHER;
 
+       if (cmd_id == SWR_BROADCAST_CMD_ID)
+               reinit_completion(&swrm->broadcast);
+
        /* Its assumed that write is okay as we do not get any status back */
        swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val);