Improve bash compatibility of heaptrack shell script.
authorMilian Wolff <mail@milianw.de>
Thu, 2 Jun 2016 10:01:29 +0000 (12:01 +0200)
committerMilian Wolff <mail@milianw.de>
Thu, 2 Jun 2016 10:01:29 +0000 (12:01 +0200)
- don't use case fall-through via ;;&
- access /proc/$pid/comm directly

heaptrack.sh.cmake

index e8f7f2b..20151fc 100755 (executable)
@@ -59,24 +59,21 @@ client=
 
 while true; do
     case "$1" in
-        "-d") ;&
-        "--debug")
+        "-d" | "--debug")
             debug=1
             shift 1
             ;;
-        "-h") ;&
-        "--help")
+        "-h" | "--help")
             usage
             exit 0
             ;;
-        "-p") ;&
-        "--pid")
+        "-p" | "--pid")
             pid=$2
             if [ -z "$pid" ]; then
                 echo "Missing PID argument."
                 exit 1
             fi
-            client=$(ps --no-headers -c -o comm -p $pid)
+            client=$(cat /proc/$pid/comm)
             if [ -z "$client" ]; then
                 echo "Cannot attach to unknown process with PID $pid."
                 exit 1
@@ -89,8 +86,7 @@ while true; do
             fi
             break
             ;;
-        "-v") ;&
-        "--version")
+        "-v" | "--version")
             echo "heaptrack @HEAPTRACK_VERSION_MAJOR@.@HEAPTRACK_VERSION_MINOR@.@HEAPTRACK_VERSION_PATCH@"
             exit 0
             ;;