fsnotify: remove redundant parameter judgment
authorBang Li <libang.linuxer@gmail.com>
Fri, 11 Mar 2022 15:12:40 +0000 (23:12 +0800)
committerJan Kara <jack@suse.cz>
Mon, 14 Mar 2022 08:05:25 +0000 (09:05 +0100)
iput() has already judged the incoming parameter, so there is no need to
repeat the judgment here.

Link: https://lore.kernel.org/r/20220311151240.62045-1-libang.linuxer@gmail.com
Signed-off-by: Bang Li <libang.linuxer@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/fsnotify.c

index 494f653..70a8516 100644 (file)
@@ -70,8 +70,7 @@ static void fsnotify_unmount_inodes(struct super_block *sb)
                spin_unlock(&inode->i_lock);
                spin_unlock(&sb->s_inode_list_lock);
 
-               if (iput_inode)
-                       iput(iput_inode);
+               iput(iput_inode);
 
                /* for each watch, send FS_UNMOUNT and then remove it */
                fsnotify_inode(inode, FS_UNMOUNT);
@@ -85,8 +84,7 @@ static void fsnotify_unmount_inodes(struct super_block *sb)
        }
        spin_unlock(&sb->s_inode_list_lock);
 
-       if (iput_inode)
-               iput(iput_inode);
+       iput(iput_inode);
 }
 
 void fsnotify_sb_delete(struct super_block *sb)