hwmon: (amc6821) Convert to use devm_ functions
authorGuenter Roeck <linux@roeck-us.net>
Sat, 2 Jun 2012 16:58:02 +0000 (09:58 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 24 Sep 2012 04:08:30 +0000 (21:08 -0700)
Convert to use devm_ functions to reduce code size and simplify the code.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/amc6821.c

index f600fa1..ae482e3 100644 (file)
@@ -862,12 +862,10 @@ static int amc6821_probe(
        struct amc6821_data *data;
        int err;
 
-       data = kzalloc(sizeof(struct amc6821_data), GFP_KERNEL);
-       if (!data) {
-               dev_err(&client->dev, "out of memory.\n");
+       data = devm_kzalloc(&client->dev, sizeof(struct amc6821_data),
+                           GFP_KERNEL);
+       if (!data)
                return -ENOMEM;
-       }
-
 
        i2c_set_clientdata(client, data);
        mutex_init(&data->update_lock);
@@ -877,11 +875,11 @@ static int amc6821_probe(
         */
        err = amc6821_init_client(client);
        if (err)
-               goto err_free;
+               return err;
 
        err = sysfs_create_group(&client->dev.kobj, &amc6821_attr_grp);
        if (err)
-               goto err_free;
+               return err;
 
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (!IS_ERR(data->hwmon_dev))
@@ -890,8 +888,6 @@ static int amc6821_probe(
        err = PTR_ERR(data->hwmon_dev);
        dev_err(&client->dev, "error registering hwmon device.\n");
        sysfs_remove_group(&client->dev.kobj, &amc6821_attr_grp);
-err_free:
-       kfree(data);
        return err;
 }
 
@@ -902,8 +898,6 @@ static int amc6821_remove(struct i2c_client *client)
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &amc6821_attr_grp);
 
-       kfree(data);
-
        return 0;
 }