usb: mtu3: add a function to switch mailbox state to string
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Thu, 21 Mar 2019 02:53:49 +0000 (10:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Mar 2019 07:40:14 +0000 (16:40 +0900)
By introducing mailbox_state_string(), allow to make debug
log more readable

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/mtu3/mtu3_dr.c

index 8291312..5fcb71a 100644 (file)
@@ -21,6 +21,22 @@ enum mtu3_vbus_id_state {
        MTU3_VBUS_VALID,
 };
 
+static char *mailbox_state_string(enum mtu3_vbus_id_state state)
+{
+       switch (state) {
+       case MTU3_ID_FLOAT:
+               return "ID_FLOAT";
+       case MTU3_ID_GROUND:
+               return "ID_GROUND";
+       case MTU3_VBUS_OFF:
+               return "VBUS_OFF";
+       case MTU3_VBUS_VALID:
+               return "VBUS_VALID";
+       default:
+               return "UNKNOWN";
+       }
+}
+
 static void toggle_opstate(struct ssusb_mtk *ssusb)
 {
        if (!ssusb->otg_switch.is_u3_drd) {
@@ -140,8 +156,8 @@ static void ssusb_set_mailbox(struct otg_switch_mtk *otg_sx,
                container_of(otg_sx, struct ssusb_mtk, otg_switch);
        struct mtu3 *mtu = ssusb->u3d;
 
-       dev_dbg(ssusb->dev, "mailbox state(%d)\n", status);
-       mtu3_dbg_trace(ssusb->dev, "mailbox %d", status);
+       dev_dbg(ssusb->dev, "mailbox %s\n", mailbox_state_string(status));
+       mtu3_dbg_trace(ssusb->dev, "mailbox %s", mailbox_state_string(status));
 
        switch (status) {
        case MTU3_ID_GROUND: