of/unittest: Add of_node_put() before return
authorWan Jiabing <wanjiabing@vivo.com>
Fri, 15 Oct 2021 08:26:58 +0000 (04:26 -0400)
committerRob Herring <robh@kernel.org>
Wed, 20 Oct 2021 18:37:25 +0000 (13:37 -0500)
Fix following coccicheck warning:
./drivers/of/unittest.c:3091:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015082658.19005-1-wanjiabing@vivo.com
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/unittest.c

index 8c05697..b8d2b66 100644 (file)
@@ -3094,6 +3094,8 @@ static __init void of_unittest_overlay_high_level(void)
                        if (!strcmp(np->full_name, base_child->full_name)) {
                                unittest(0, "illegal node name in overlay_base %pOFn",
                                         np);
+                               of_node_put(np);
+                               of_node_put(base_child);
                                return;
                        }
                }