cpuidle: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:03 +0000 (08:47 -0600)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 27 Mar 2023 17:08:12 +0000 (19:08 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/cpuidle-psci-domain.c
drivers/cpuidle/cpuidle-riscv-sbi.c

index 11316c3..c2d6d9c 100644 (file)
@@ -166,7 +166,7 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
         * initialize a genpd/genpd-of-provider pair when it's found.
         */
        for_each_child_of_node(np, node) {
-               if (!of_find_property(node, "#power-domain-cells", NULL))
+               if (!of_property_present(node, "#power-domain-cells"))
                        continue;
 
                ret = psci_pd_init(node, use_osi);
index be383f4..1fab1ab 100644 (file)
@@ -497,7 +497,7 @@ static int sbi_genpd_probe(struct device_node *np)
         * initialize a genpd/genpd-of-provider pair when it's found.
         */
        for_each_child_of_node(np, node) {
-               if (!of_find_property(node, "#power-domain-cells", NULL))
+               if (!of_property_present(node, "#power-domain-cells"))
                        continue;
 
                ret = sbi_pd_init(node);
@@ -548,8 +548,8 @@ static int sbi_cpuidle_probe(struct platform_device *pdev)
        for_each_possible_cpu(cpu) {
                np = of_cpu_device_node_get(cpu);
                if (np &&
-                   of_find_property(np, "power-domains", NULL) &&
-                   of_find_property(np, "power-domain-names", NULL)) {
+                   of_property_present(np, "power-domains") &&
+                   of_property_present(np, "power-domain-names")) {
                        continue;
                } else {
                        sbi_cpuidle_use_osi = false;