r8152: Check for unplug in rtl_phy_patch_request()
authorDouglas Anderson <dianders@chromium.org>
Fri, 20 Oct 2023 21:06:56 +0000 (14:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Nov 2023 13:11:01 +0000 (14:11 +0100)
[ Upstream commit dc90ba37a8c37042407fa6970b9830890cfe6047 ]

If the adapter is unplugged while we're looping in
rtl_phy_patch_request() we could end up looping for 10 seconds (2 ms *
5000 loops). Add code similar to what's done in other places in the
driver to check for unplug and bail.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/r8152.c

index c34974f..3cdb7ff 100644 (file)
@@ -4058,6 +4058,9 @@ static int rtl_phy_patch_request(struct r8152 *tp, bool request, bool wait)
        for (i = 0; wait && i < 5000; i++) {
                u32 ocp_data;
 
+               if (test_bit(RTL8152_UNPLUG, &tp->flags))
+                       break;
+
                usleep_range(1000, 2000);
                ocp_data = ocp_reg_read(tp, OCP_PHY_PATCH_STAT);
                if ((ocp_data & PATCH_READY) ^ check)