a2dp-codecs & avinfo: Fix parsing MPEG bit rate values

Redefine bitrate field in a2dp_mpeg_t struct in endian neutral way and
separate vbr field according to A2DP specification. Define new macros
MPEG_GET_BITRATE() and MPEG_SET_BITRATE() for manipulating with bitrate
like for a2dp_aac_t struct.

And fix meaning of bitrate field. According to A2DP specification, it is
bitrate index, not bitrate itself. According to MPEG specification, each
MPEG layer have different bitrates for bitrate indexes. Therefore define
correctly bitrates for Layers 1, 2 and 3.

This fixes problems with parsing bitrate field in a2dp_mpeg_t struct as it
was broken due to endianity and it was broken for Layer 1 and 2 as bitrate
definitions was for Layer 3.

Change-Id: Ied2e860f5c54ccd6bbef7770959f5ac553022a56
Signed-off-by: himanshu <h.himanshu@samsung.com>

diff --git a/profiles/audio/a2dp-codecs.h b/profiles/audio/a2dp-codecs.h
index 2595990..47030bc 100755 (executable)
--- a/profiles/audio/a2dp-codecs.h
+++ b/profiles/audio/a2dp-codecs.h
@@ -68,22 +68,75 @@
 #define MPEG_SAMPLING_FREQ_44100       (1 << 1)
 #define MPEG_SAMPLING_FREQ_48000       1
 
-#define MPEG_BIT_RATE_VBR              0x8000
-#define MPEG_BIT_RATE_320000           0x4000
-#define MPEG_BIT_RATE_256000           0x2000
-#define MPEG_BIT_RATE_224000           0x1000
-#define MPEG_BIT_RATE_192000           0x0800
-#define MPEG_BIT_RATE_160000           0x0400
-#define MPEG_BIT_RATE_128000           0x0200
-#define MPEG_BIT_RATE_112000           0x0100
-#define MPEG_BIT_RATE_96000            0x0080
-#define MPEG_BIT_RATE_80000            0x0040
-#define MPEG_BIT_RATE_64000            0x0020
-#define MPEG_BIT_RATE_56000            0x0010
-#define MPEG_BIT_RATE_48000            0x0008
-#define MPEG_BIT_RATE_40000            0x0004
-#define MPEG_BIT_RATE_32000            0x0002
-#define MPEG_BIT_RATE_FREE             0x0001
+#define MPEG_BIT_RATE_INDEX_0          (1 << 0)
+#define MPEG_BIT_RATE_INDEX_1          (1 << 1)
+#define MPEG_BIT_RATE_INDEX_2          (1 << 2)
+#define MPEG_BIT_RATE_INDEX_3          (1 << 3)
+#define MPEG_BIT_RATE_INDEX_4          (1 << 4)
+#define MPEG_BIT_RATE_INDEX_5          (1 << 5)
+#define MPEG_BIT_RATE_INDEX_6          (1 << 6)
+#define MPEG_BIT_RATE_INDEX_7          (1 << 7)
+#define MPEG_BIT_RATE_INDEX_8          (1 << 8)
+#define MPEG_BIT_RATE_INDEX_9          (1 << 9)
+#define MPEG_BIT_RATE_INDEX_10         (1 << 10)
+#define MPEG_BIT_RATE_INDEX_11         (1 << 11)
+#define MPEG_BIT_RATE_INDEX_12         (1 << 12)
+#define MPEG_BIT_RATE_INDEX_13         (1 << 13)
+#define MPEG_BIT_RATE_INDEX_14         (1 << 14)
+
+#define MPEG_MP1_BIT_RATE_32000                MPEG_BIT_RATE_INDEX_1
+#define MPEG_MP1_BIT_RATE_64000                MPEG_BIT_RATE_INDEX_2
+#define MPEG_MP1_BIT_RATE_96000                MPEG_BIT_RATE_INDEX_3
+#define MPEG_MP1_BIT_RATE_128000       MPEG_BIT_RATE_INDEX_4
+#define MPEG_MP1_BIT_RATE_160000       MPEG_BIT_RATE_INDEX_5
+#define MPEG_MP1_BIT_RATE_192000       MPEG_BIT_RATE_INDEX_6
+#define MPEG_MP1_BIT_RATE_224000       MPEG_BIT_RATE_INDEX_7
+#define MPEG_MP1_BIT_RATE_256000       MPEG_BIT_RATE_INDEX_8
+#define MPEG_MP1_BIT_RATE_288000       MPEG_BIT_RATE_INDEX_9
+#define MPEG_MP1_BIT_RATE_320000       MPEG_BIT_RATE_INDEX_10
+#define MPEG_MP1_BIT_RATE_352000       MPEG_BIT_RATE_INDEX_11
+#define MPEG_MP1_BIT_RATE_384000       MPEG_BIT_RATE_INDEX_12
+#define MPEG_MP1_BIT_RATE_416000       MPEG_BIT_RATE_INDEX_13
+#define MPEG_MP1_BIT_RATE_448000       MPEG_BIT_RATE_INDEX_14
+
+#define MPEG_MP2_BIT_RATE_32000                MPEG_BIT_RATE_INDEX_1
+#define MPEG_MP2_BIT_RATE_48000                MPEG_BIT_RATE_INDEX_2
+#define MPEG_MP2_BIT_RATE_56000                MPEG_BIT_RATE_INDEX_3
+#define MPEG_MP2_BIT_RATE_64000                MPEG_BIT_RATE_INDEX_4
+#define MPEG_MP2_BIT_RATE_80000                MPEG_BIT_RATE_INDEX_5
+#define MPEG_MP2_BIT_RATE_96000                MPEG_BIT_RATE_INDEX_6
+#define MPEG_MP2_BIT_RATE_112000       MPEG_BIT_RATE_INDEX_7
+#define MPEG_MP2_BIT_RATE_128000       MPEG_BIT_RATE_INDEX_8
+#define MPEG_MP2_BIT_RATE_160000       MPEG_BIT_RATE_INDEX_9
+#define MPEG_MP2_BIT_RATE_192000       MPEG_BIT_RATE_INDEX_10
+#define MPEG_MP2_BIT_RATE_224000       MPEG_BIT_RATE_INDEX_11
+#define MPEG_MP2_BIT_RATE_256000       MPEG_BIT_RATE_INDEX_12
+#define MPEG_MP2_BIT_RATE_320000       MPEG_BIT_RATE_INDEX_13
+#define MPEG_MP2_BIT_RATE_384000       MPEG_BIT_RATE_INDEX_14
+
+#define MPEG_MP3_BIT_RATE_32000                MPEG_BIT_RATE_INDEX_1
+#define MPEG_MP3_BIT_RATE_40000                MPEG_BIT_RATE_INDEX_2
+#define MPEG_MP3_BIT_RATE_48000                MPEG_BIT_RATE_INDEX_3
+#define MPEG_MP3_BIT_RATE_56000                MPEG_BIT_RATE_INDEX_4
+#define MPEG_MP3_BIT_RATE_64000                MPEG_BIT_RATE_INDEX_5
+#define MPEG_MP3_BIT_RATE_80000                MPEG_BIT_RATE_INDEX_6
+#define MPEG_MP3_BIT_RATE_96000                MPEG_BIT_RATE_INDEX_7
+#define MPEG_MP3_BIT_RATE_112000       MPEG_BIT_RATE_INDEX_8
+#define MPEG_MP3_BIT_RATE_128000       MPEG_BIT_RATE_INDEX_9
+#define MPEG_MP3_BIT_RATE_160000       MPEG_BIT_RATE_INDEX_10
+#define MPEG_MP3_BIT_RATE_192000       MPEG_BIT_RATE_INDEX_11
+#define MPEG_MP3_BIT_RATE_224000       MPEG_BIT_RATE_INDEX_12
+#define MPEG_MP3_BIT_RATE_256000       MPEG_BIT_RATE_INDEX_13
+#define MPEG_MP3_BIT_RATE_320000       MPEG_BIT_RATE_INDEX_14
+
+#define MPEG_BIT_RATE_FREE             MPEG_BIT_RATE_INDEX_0
+
+#define MPEG_GET_BITRATE(a) ((uint16_t)(a).bitrate1 << 8 | (a).bitrate2)
+#define MPEG_SET_BITRATE(a, b) \
+       do { \
+               (a).bitrate1 = ((b) >> 8) & 0x7f; \
+               (a).bitrate2 = (b) & 0xff; \
+       } while (0)
 
 #define AAC_OBJECT_TYPE_MPEG2_AAC_LC   0x80
 #define AAC_OBJECT_TYPE_MPEG4_AAC_LC   0x40
@@ -168,7 +221,9 @@ typedef struct {
        uint8_t frequency:6;
        uint8_t mpf:1;
        uint8_t rfa:1;
-       uint16_t bitrate;
+       uint8_t bitrate1:7;
+       uint8_t vbr:1;
+       uint8_t bitrate2;
 } __attribute__ ((packed)) a2dp_mpeg_t;
 
 typedef struct {
@@ -213,7 +268,9 @@ typedef struct {
        uint8_t rfa:1;
        uint8_t mpf:1;
        uint8_t frequency:6;
-       uint16_t bitrate;
+       uint8_t vbr:1;
+       uint8_t bitrate1:7;
+       uint8_t bitrate2;
 } __attribute__ ((packed)) a2dp_mpeg_t;
 
 typedef struct {

diff --git a/tools/avinfo.c b/tools/avinfo.c
index 61bcdab..2398cc5 100755 (executable)
--- a/tools/avinfo.c
+++ b/tools/avinfo.c
@@ -303,11 +303,15 @@ static void print_mpeg24(a2dp_aac_t *aac, uint8_t size)
 
 static void print_mpeg12(a2dp_mpeg_t *mpeg, uint8_t size)
 {
+       uint16_t bitrate;
+
        if (size < sizeof(*mpeg)) {
                printf("\tMedia Codec: MPEG12 (broken)\n");
                return;
        }
 
+       bitrate = MPEG_GET_BITRATE(*mpeg);
+
        printf("\tMedia Codec: MPEG12\n\t\tChannel Modes: ");
 
        if (mpeg->channel_mode & MPEG_CHANNEL_MODE_MONO)
@@ -343,42 +347,105 @@ static void print_mpeg12(a2dp_mpeg_t *mpeg, uint8_t size)
        if (mpeg->layer & MPEG_LAYER_MP3)
                printf("3 ");
 
-       printf("\n\t\tBit Rate: ");
-       if (mpeg->bitrate & MPEG_BIT_RATE_FREE)
-               printf("Free format");
-       else {
-               if (mpeg->bitrate & MPEG_BIT_RATE_32000)
-                       printf("32kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_40000)
-                       printf("40kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_48000)
-                       printf("48kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_56000)
-                       printf("56kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_64000)
-                       printf("64kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_80000)
-                       printf("80kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_96000)
-                       printf("96kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_112000)
-                       printf("112kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_128000)
-                       printf("128kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_160000)
-                       printf("160kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_192000)
-                       printf("192kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_224000)
-                       printf("224kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_256000)
-                       printf("256kbps ");
-               if (mpeg->bitrate & MPEG_BIT_RATE_320000)
-                       printf("320kbps ");
+       if (bitrate & MPEG_BIT_RATE_FREE) {
+               printf("\n\t\tBit Rate: Free format");
+       } else {
+               if (mpeg->layer & MPEG_LAYER_MP1) {
+                       printf("\n\t\tLayer 1 Bit Rate: ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_32000)
+                               printf("32kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_64000)
+                               printf("64kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_96000)
+                               printf("96kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_128000)
+                               printf("128kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_160000)
+                               printf("160kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_192000)
+                               printf("192kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_224000)
+                               printf("224kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_256000)
+                               printf("256kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_320000)
+                               printf("320kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_352000)
+                               printf("352kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_384000)
+                               printf("384kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_416000)
+                               printf("416kbps ");
+                       if (bitrate & MPEG_MP1_BIT_RATE_448000)
+                               printf("448kbps ");
+               }
+
+               if (mpeg->layer & MPEG_LAYER_MP2) {
+                       printf("\n\t\tLayer 2 Bit Rate: ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_32000)
+                               printf("32kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_48000)
+                               printf("48kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_56000)
+                               printf("56kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_64000)
+                               printf("64kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_80000)
+                               printf("80kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_96000)
+                               printf("96kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_112000)
+                               printf("112kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_128000)
+                               printf("128kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_160000)
+                               printf("160kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_192000)
+                               printf("192kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_224000)
+                               printf("224kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_256000)
+                               printf("256kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_320000)
+                               printf("320kbps ");
+                       if (bitrate & MPEG_MP2_BIT_RATE_384000)
+                               printf("384kbps ");
+               }
+
+               if (mpeg->layer & MPEG_LAYER_MP3) {
+                       printf("\n\t\tLayer 3 Bit Rate: ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_32000)
+                               printf("32kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_40000)
+                               printf("40kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_48000)
+                               printf("48kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_56000)
+                               printf("56kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_64000)
+                               printf("64kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_80000)
+                               printf("80kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_96000)
+                               printf("96kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_112000)
+                               printf("112kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_128000)
+                               printf("128kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_160000)
+                               printf("160kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_192000)
+                               printf("192kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_224000)
+                               printf("224kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_256000)
+                               printf("256kbps ");
+                       if (bitrate & MPEG_MP3_BIT_RATE_320000)
+                               printf("320kbps ");
+               }
        }
 
-       printf("\n\t\tVBR: %s", mpeg->bitrate & MPEG_BIT_RATE_VBR ? "Yes" :
-               "No");
+       printf("\n\t\tVBR: %s", mpeg->vbr ? "Yes" : "No");
 
        printf("\n\t\tPayload Format: ");
        if (mpeg->mpf)