bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()

The error message emitted in fsl_mc_driver_remove() is very generic.
Replace it by a message that mentions the reason for the failure.

Returning zero instead of a negative value has no side effect apart from
suppressing the generic error message.

The first if condition in dprc_remove() can never be true, as this would
prevent successful probing of the device and then .remove wasn't called.
So this can just be dropped.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>

diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
index 4c84be3..ef4f43f 100644 (file)
--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -839,11 +839,10 @@ static int dprc_remove(struct fsl_mc_device *mc_dev)
 {
        struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_dev);
 
-       if (!is_fsl_mc_bus_dprc(mc_dev))
-               return -EINVAL;
-
-       if (!mc_bus->irq_resources)
-               return -EINVAL;
+       if (!mc_bus->irq_resources) {
+               dev_err(&mc_dev->dev, "No irq resources, so unbinding the device failed\n");
+               return 0;
+       }
 
        if (dev_get_msi_domain(&mc_dev->dev))
                dprc_teardown_irq(mc_dev);