rtc: pcf85063: fix pcf85063_clkout_control
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 11 Dec 2022 22:35:53 +0000 (23:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:37 +0000 (13:14 +0100)
[ Upstream commit c2d12e85336f6d4172fb2bab5935027c446d7343 ]

pcf85063_clkout_control reads the wrong register but then update the
correct one.

Reported-by: Janne Terho <janne.terho@ouman.fi>
Fixes: 8c229ab6048b ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
Link: https://lore.kernel.org/r/20221211223553.59955-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-pcf85063.c

index 3e28377..bf2e370 100644 (file)
@@ -422,7 +422,7 @@ static int pcf85063_clkout_control(struct clk_hw *hw, bool enable)
        unsigned int buf;
        int ret;
 
-       ret = regmap_read(pcf85063->regmap, PCF85063_REG_OFFSET, &buf);
+       ret = regmap_read(pcf85063->regmap, PCF85063_REG_CTRL2, &buf);
        if (ret < 0)
                return ret;
        buf &= PCF85063_REG_CLKO_F_MASK;