net/mlx5e: Use #define for the WQE wait timeout constant
authorMaxim Mikityanskiy <maximmi@mellanox.com>
Tue, 5 Mar 2019 12:46:16 +0000 (14:46 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 23 Apr 2019 19:09:22 +0000 (12:09 -0700)
Create a #define for the timeout of mlx5e_wait_for_min_rx_wqes to
clarify the meaning of a magic number.

Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 8ae17dc..69a9d67 100644 (file)
@@ -2256,14 +2256,18 @@ static void mlx5e_activate_channels(struct mlx5e_channels *chs)
                mlx5e_activate_channel(chs->c[i]);
 }
 
+#define MLX5E_RQ_WQES_TIMEOUT 20000 /* msecs */
+
 static int mlx5e_wait_channels_min_rx_wqes(struct mlx5e_channels *chs)
 {
        int err = 0;
        int i;
 
-       for (i = 0; i < chs->num; i++)
-               err |= mlx5e_wait_for_min_rx_wqes(&chs->c[i]->rq,
-                                                 err ? 0 : 20000);
+       for (i = 0; i < chs->num; i++) {
+               int timeout = err ? 0 : MLX5E_RQ_WQES_TIMEOUT;
+
+               err |= mlx5e_wait_for_min_rx_wqes(&chs->c[i]->rq, timeout);
+       }
 
        return err ? -ETIMEDOUT : 0;
 }