USB: serial: mos7840: drop read-urb check
authorJohan Hovold <johan@kernel.org>
Thu, 7 Nov 2019 13:29:03 +0000 (14:29 +0100)
committerJohan Hovold <johan@kernel.org>
Tue, 12 Nov 2019 08:57:26 +0000 (09:57 +0100)
Drop read-urb check which is always false from completion the callback.

The driver read-urb pointer is set at every open and is never cleared.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c

index 11706f2..f5c08ef 100644 (file)
@@ -457,12 +457,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
                dev_dbg(&port->dev, "icount.rx is %d:\n", port->icount.rx);
        }
 
-       if (!mos7840_port->read_urb) {
-               dev_dbg(&port->dev, "%s", "URB KILLED !!!\n");
-               mos7840_port->read_urb_busy = false;
-               return;
-       }
-
        if (mos7840_port->has_led)
                mos7840_led_activity(port);
 
@@ -1377,11 +1371,6 @@ static void mos7840_set_termios(struct tty_struct *tty,
 
        mos7840_change_port_settings(tty, mos7840_port, old_termios);
 
-       if (!mos7840_port->read_urb) {
-               dev_dbg(&port->dev, "%s", "URB KILLED !!!!!\n");
-               return;
-       }
-
        if (!mos7840_port->read_urb_busy) {
                mos7840_port->read_urb_busy = true;
                status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL);