[DWP][DWARF] Detect and error on debug info offset overflow
authorAlexander Yermolovich <ayermolo@fb.com>
Fri, 22 Jul 2022 20:10:13 +0000 (13:10 -0700)
committerAlexander Yermolovich <ayermolo@fb.com>
Tue, 26 Jul 2022 15:18:59 +0000 (08:18 -0700)
Right now we silently overflow uint32_t for debug_indfo sections. Added a check
and error out.

Differential Revision: https://reviews.llvm.org/D130395

llvm/lib/DWP/DWP.cpp

index 44e39c0..346f4df 100644 (file)
@@ -18,6 +18,7 @@
 #include "llvm/Object/Decompressor.h"
 #include "llvm/Object/ELFObjectFile.h"
 #include "llvm/Support/MemoryBuffer.h"
+#include <limits>
 
 using namespace llvm;
 using namespace llvm::object;
@@ -654,6 +655,12 @@ Error write(MCStreamer &Out, ArrayRef<std::string> Inputs) {
                                                              IndexVersion)];
           C.Offset = InfoSectionOffset;
           C.Length = Header.Length + 4;
+
+          if (std::numeric_limits<uint32_t>::max() - InfoSectionOffset <
+              C.Length)
+            return make_error<DWPError>(
+                "debug information section offset is greater than 4GB");
+
           UnitOffset += C.Length;
           if (Header.Version < 5 ||
               Header.UnitType == dwarf::DW_UT_split_compile) {