There is an analogous ``zero_call_used_regs`` attribute to allow for finer
control of this feature.
+Bug Fixes
+------------------
+- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional``
+ wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array
+ size expression. This was fixed and ``::getArraySize()`` will now always
+ either return ``None`` or a ``llvm::Optional`` wrapping a valid ``Expr*``.
+ This fixes `Issue #53742<https://github.com/llvm/llvm-project/issues/53742>`_.
+
Improvements to Clang's diagnostics
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- Added support for parameter pack expansion in `clang::annotate`.
- The ``overloadable`` attribute can now be written in all of the syntactic
- locations a declaration attribute may appear. Fixes PR53805.
+ locations a declaration attribute may appear.
+ This fixes `Issue #53805<https://github.com/llvm/llvm-project/issues/53805>`_.
Windows Support
---------------
bool isArray() const { return CXXNewExprBits.IsArray; }
+ /// This might return None even if isArray() returns true,
+ /// since there might not be an array size expression.
+ /// If the result is not-None, it will never wrap a nullptr.
Optional<Expr *> getArraySize() {
if (!isArray())
return None;
- return cast_or_null<Expr>(getTrailingObjects<Stmt *>()[arraySizeOffset()]);
+
+ if (auto *Result =
+ cast_or_null<Expr>(getTrailingObjects<Stmt *>()[arraySizeOffset()]))
+ return Result;
+
+ return None;
}
+
+ /// This might return None even if isArray() returns true,
+ /// since there might not be an array size expression.
+ /// If the result is not-None, it will never wrap a nullptr.
Optional<const Expr *> getArraySize() const {
if (!isArray())
return None;
- return cast_or_null<Expr>(getTrailingObjects<Stmt *>()[arraySizeOffset()]);
+
+ if (auto *Result =
+ cast_or_null<Expr>(getTrailingObjects<Stmt *>()[arraySizeOffset()]))
+ return Result;
+
+ return None;
}
unsigned getNumPlacementArgs() const {
bool ValueInit = false;
QualType AllocType = E->getAllocatedType();
- if (Optional<const Expr*> ArraySize = E->getArraySize()) {
+ if (Optional<const Expr *> ArraySize = E->getArraySize()) {
const Expr *Stripped = *ArraySize;
for (; auto *ICE = dyn_cast<ImplicitCastExpr>(Stripped);
Stripped = ICE->getSubExpr())
if (E->isParenTypeId())
OS << "(";
std::string TypeS;
- if (Optional<Expr *> Size = E->getArraySize()) {
+ if (E->isArray()) {
llvm::raw_string_ostream s(TypeS);
s << '[';
- if (*Size)
+ if (Optional<Expr *> Size = E->getArraySize())
(*Size)->printPretty(s, Helper, Policy);
s << ']';
}
// Transform the size of the array we're allocating (if any).
Optional<Expr *> ArraySize;
- if (Optional<Expr *> OldArraySize = E->getArraySize()) {
+ if (E->isArray()) {
ExprResult NewArraySize;
- if (*OldArraySize) {
+ if (Optional<Expr *> OldArraySize = E->getArraySize()) {
NewArraySize = getDerived().TransformExpr(*OldArraySize);
if (NewArraySize.isInvalid())
return ExprError();
--- /dev/null
+// RUN: %clang_cc1 -fsyntax-only %s -verify
+
+struct Data {
+ char *a;
+ char *b;
+ bool *c;
+};
+
+int main() {
+ Data in;
+ in.a = new char[](); // expected-error {{cannot determine allocated array size from initializer}}
+ in.c = new bool[100]();
+ in.b = new char[100]();
+}