ubifs: Fix WARN_ON logic in exit path
authorRichard Weinberger <richard@nod.at>
Sat, 13 Oct 2018 08:18:41 +0000 (10:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Oct 2018 09:05:02 +0000 (11:05 +0200)
ubifs_assert() is not WARN_ON(), so we have to invert
the checks.
Randy faced this warning with UBIFS being a module, since
most users use UBIFS as builtin because UBIFS is the rootfs
nobody noticed so far. :-(
Including me.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 54169ddd382d ("ubifs: Turn two ubifs_assert() into a WARN_ON()")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ubifs/super.c

index bf000c8aeffbb30fe8b1ebbed322540021f0bb55..fec62e9dfbe6a6c639d7f61879bf21ac84ef4a6c 100644 (file)
@@ -2337,8 +2337,8 @@ late_initcall(ubifs_init);
 
 static void __exit ubifs_exit(void)
 {
-       WARN_ON(list_empty(&ubifs_infos));
-       WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
+       WARN_ON(!list_empty(&ubifs_infos));
+       WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) != 0);
 
        dbg_debugfs_exit();
        ubifs_compressors_exit();