Plug a leak introduced by r240848
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 27 Jun 2015 00:15:32 +0000 (00:15 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 27 Jun 2015 00:15:32 +0000 (00:15 +0000)
Apparently this obvious leak was never exercised before, but r240848
exposed it.  Plug it.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5075

llvm-svn: 240865

llvm/lib/IR/AsmWriter.cpp

index 7efb8e2..fdfed9e 100644 (file)
@@ -1941,8 +1941,11 @@ static void WriteAsOperandInternal(raw_ostream &Out, const Metadata *MD,
                                    SlotTracker *Machine, const Module *Context,
                                    bool FromValue) {
   if (const MDNode *N = dyn_cast<MDNode>(MD)) {
-    if (!Machine)
-      Machine = new SlotTracker(Context);
+    std::unique_ptr<SlotTracker> MachineStorage;
+    if (!Machine) {
+      MachineStorage = make_unique<SlotTracker>(Context);
+      Machine = MachineStorage.get();
+    }
     int Slot = Machine->getMetadataSlot(N);
     if (Slot == -1)
       // Give the pointer value instead of "badref", since this comes up all