md/raid10: fix wrong setting of max_corr_read_errors
authorLi Nan <linan122@huawei.com>
Mon, 22 May 2023 07:25:34 +0000 (15:25 +0800)
committerSong Liu <song@kernel.org>
Tue, 13 Jun 2023 22:13:22 +0000 (15:13 -0700)
There is no input check when echo md/max_read_errors and overflow might
occur. Add check of input number.

Fixes: 1e50915fe0bb ("raid: improve MD/raid10 handling of correctable read errors.")
Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230522072535.1523740-3-linan666@huaweicloud.com
drivers/md/md.c

index 2fc8d25..49c83ed 100644 (file)
@@ -4468,6 +4468,8 @@ max_corrected_read_errors_store(struct mddev *mddev, const char *buf, size_t len
        rv = kstrtouint(buf, 10, &n);
        if (rv < 0)
                return rv;
+       if (n > INT_MAX)
+               return -EINVAL;
        atomic_set(&mddev->max_corr_read_errors, n);
        return len;
 }