spi: tegra210-quad: use devm call for cdata memory
authorKrishna Yarlagadda <kyarlagadda@nvidia.com>
Thu, 25 Nov 2021 09:55:51 +0000 (15:25 +0530)
committerMark Brown <broonie@kernel.org>
Fri, 26 Nov 2021 13:24:39 +0000 (13:24 +0000)
Use devm alloc call to allocate memory for spi controller data and
remove free calls from cleanup.

Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Link: https://lore.kernel.org/r/1637834152-32093-1-git-send-email-kyarlagadda@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index c0f9a75..ce1bdb4 100644 (file)
@@ -877,7 +877,7 @@ static struct tegra_qspi_client_data *tegra_qspi_parse_cdata_dt(struct spi_devic
        struct tegra_qspi_client_data *cdata;
        struct device_node *slave_np = spi->dev.of_node;
 
-       cdata = kzalloc(sizeof(*cdata), GFP_KERNEL);
+       cdata = devm_kzalloc(&spi->dev, sizeof(*cdata), GFP_KERNEL);
        if (!cdata)
                return NULL;
 
@@ -888,14 +888,6 @@ static struct tegra_qspi_client_data *tegra_qspi_parse_cdata_dt(struct spi_devic
        return cdata;
 }
 
-static void tegra_qspi_cleanup(struct spi_device *spi)
-{
-       struct tegra_qspi_client_data *cdata = spi->controller_data;
-
-       spi->controller_data = NULL;
-       kfree(cdata);
-}
-
 static int tegra_qspi_setup(struct spi_device *spi)
 {
        struct tegra_qspi *tqspi = spi_master_get_devdata(spi->master);
@@ -1229,7 +1221,6 @@ static int tegra_qspi_probe(struct platform_device *pdev)
                            SPI_TX_DUAL | SPI_RX_DUAL | SPI_TX_QUAD | SPI_RX_QUAD;
        master->bits_per_word_mask = SPI_BPW_MASK(32) | SPI_BPW_MASK(16) | SPI_BPW_MASK(8);
        master->setup = tegra_qspi_setup;
-       master->cleanup = tegra_qspi_cleanup;
        master->transfer_one_message = tegra_qspi_transfer_one_message;
        master->num_chipselect = 1;
        master->auto_runtime_pm = true;