fix coverity

- COPY INSTEAD OF MOVE

Change-Id: I916b7bebcf54045e6bce34cb68f15f083f6b02e4

diff --git a/libaurum/inc/Until.h b/libaurum/inc/Until.h
index 0fd797e7a0083397226b8b81e1e86df25fbd3c01..f1f1abfcabce260049ce5eadb24f46e6ab040327 100644 (file)
--- a/libaurum/inc/Until.h
+++ b/libaurum/inc/Until.h
@@ -88,7 +88,7 @@ public:
      * @since_tizen 6.5
      */
     static std::function<bool(const ISearchable *)> hasObject(
-        const std::shared_ptr<UiSelector> selector);
+        const std::shared_ptr<UiSelector> &selector);
 
     /**
      * @brief Checks that there is an object that are satisfied with selector condition.
@@ -101,7 +101,7 @@ public:
      * @since_tizen 6.5
      */
     static std::function<std::shared_ptr<UiObject>(const ISearchable *)>
-                                                 findObject(const std::shared_ptr<UiSelector> selector);
+                                                 findObject(const std::shared_ptr<UiSelector> &selector);
 
     /**
      * @brief Checks the given object on checkable state.
@@ -127,7 +127,7 @@ public:
      * @since_tizen 7.0
      */
     static std::function<std::vector<std::shared_ptr<UiObject>>(const ISearchable *)>
-                                                 findObjects(const std::shared_ptr<UiSelector> selector);
+                                                 findObjects(const std::shared_ptr<UiSelector> &selector);
 };
 
 }

diff --git a/libaurum/src/Until.cc b/libaurum/src/Until.cc
index 0affb12cae092e72dad1cf8201f84ae1059f4be5..0843f92c9b9c19392d122f8676c152110788695f 100644 (file)
--- a/libaurum/src/Until.cc
+++ b/libaurum/src/Until.cc
@@ -20,7 +20,7 @@
 using namespace Aurum;
 
 std::function<bool(const ISearchable *)> Until::hasObject(
-    const std::shared_ptr<UiSelector> selector)
+    const std::shared_ptr<UiSelector> &selector)
 {
     return [=](const ISearchable *searchable) -> bool {
         LOGI("hasObject search:%p", searchable);
@@ -30,7 +30,7 @@ std::function<bool(const ISearchable *)> Until::hasObject(
 }
 
 std::function<std::shared_ptr<UiObject>(const ISearchable *)> Until::findObject(
-    const std::shared_ptr<UiSelector> selector)
+    const std::shared_ptr<UiSelector> &selector)
 {
     return [=](const ISearchable *searchable) -> std::shared_ptr<UiObject> {
         LOGI("findObject search:%p", searchable);
@@ -48,7 +48,7 @@ std::function<bool(const UiObject *)> Until::checkable(const bool isCheckable)
 }
 
 std::function<std::vector<std::shared_ptr<UiObject>>(const ISearchable *)> Until::findObjects(
-    const std::shared_ptr<UiSelector> selector)
+    const std::shared_ptr<UiSelector> &selector)
 {
     return [=](const ISearchable *searchable) -> std::vector<std::shared_ptr<UiObject>> {
         LOGI("findObjects search:%p", searchable);

diff --git a/org.tizen.aurum-bootstrap/inc/Commands/DumpObjectTreeCommand.h b/org.tizen.aurum-bootstrap/inc/Commands/DumpObjectTreeCommand.h
index f24843693aedc5573dcdbc73c560c2a6a901d2ac..56aff845ec7e1662698a027a2e05b7f31afbcd56 100644 (file)
--- a/org.tizen.aurum-bootstrap/inc/Commands/DumpObjectTreeCommand.h
+++ b/org.tizen.aurum-bootstrap/inc/Commands/DumpObjectTreeCommand.h
@@ -31,5 +31,5 @@ public:
     ::grpc::Status execute() override;
 
 private:
-    void traverse(::aurum::Element *root, std::shared_ptr<Node> node, int depth);
+    void traverse(::aurum::Element *root, const std::shared_ptr<Node> &node, int depth);
 };

diff --git a/org.tizen.aurum-bootstrap/src/Commands/DumpObjectTreeCommand.cc b/org.tizen.aurum-bootstrap/src/Commands/DumpObjectTreeCommand.cc
index a98bfe4e9e0123f59c7e94319517f04e777c7c95..91e7837fe31c872bcb10864a3e4469589fc0fb5f 100644 (file)
--- a/org.tizen.aurum-bootstrap/src/Commands/DumpObjectTreeCommand.cc
+++ b/org.tizen.aurum-bootstrap/src/Commands/DumpObjectTreeCommand.cc
@@ -30,7 +30,7 @@ DumpObjectTreeCommand::DumpObjectTreeCommand(const ::aurum::ReqDumpObjectTree *r
     mObjMap = ObjectMapper::getInstance();
 }
 
-void DumpObjectTreeCommand::traverse(::aurum::Element *root, std::shared_ptr<Node> node, int depth)
+void DumpObjectTreeCommand::traverse(::aurum::Element *root, const std::shared_ptr<Node> &node, int depth)
 {
     if (!node->mNode) return;
     std::shared_ptr<UiObject> obj = node->mNode;