elm elm_spinner.c/h: Use proper variable name. Add more comments.
authorDaniel Juyung Seo <seojuyung@gmail.com>
Sat, 2 Mar 2013 14:50:35 +0000 (23:50 +0900)
committerDaniel Juyung Seo <seojuyung@gmail.com>
Sat, 2 Mar 2013 15:38:35 +0000 (00:38 +0900)
1. drag_start_pos -> drag_start_val. This is a value not a position.
2. added comment for drag_start_val.

legacy/elementary/src/lib/elm_spinner.c
legacy/elementary/src/lib/elm_widget_spinner.h

index 7f3ae49..765f589 100644 (file)
@@ -174,7 +174,7 @@ _drag_cb(void *data,
    delta = pos * offset;
    /* If we are on rtl mode, change the delta to be negative on such changes */
    if (elm_widget_mirrored_get(obj)) delta *= -1;
-   if (_value_set(data, sd->drag_start_pos + delta)) _label_write(data);
+   if (_value_set(data, sd->drag_start_val + delta)) _label_write(data);
    sd->dragging = 1;
 }
 
@@ -186,7 +186,7 @@ _drag_start_cb(void *data,
 {
    ELM_SPINNER_DATA_GET(data, sd);
 
-   sd->drag_start_pos = sd->val;
+   sd->drag_start_val = sd->val;
 }
 
 static void
@@ -198,7 +198,7 @@ _drag_stop_cb(void *data,
    ELM_SPINNER_DATA_GET(data, sd);
    Elm_Widget_Smart_Data *wd = eo_data_get(data, ELM_OBJ_WIDGET_CLASS);
 
-   sd->drag_start_pos = 0;
+   sd->drag_start_val = 0;
    edje_object_part_drag_value_set
      (wd->resize_obj, "elm.dragable.slider", 0.0, 0.0);
 }
index 74b0ade..f014c0f 100644 (file)
@@ -26,8 +26,11 @@ struct _Elm_Spinner_Smart_Data
 {
    Evas_Object          *ent;
    const char           *label;
-   double                val, val_min, val_max, orig_val, step, val_base;
-   double                drag_start_pos, spin_speed, interval, first_interval;
+   double                val, val_min, val_max, orig_val, val_base;
+   double                step; // step for the value change. 1 by default.
+   double                drag_start_val; // spinner value on drag start.
+                                         // this is reset to 0 when drag stops.
+   double                spin_speed, interval, first_interval;
    int                   round;
    Ecore_Timer          *delay, *spin;
    Eina_List            *special_values;