s390/con3270: fix multiple assignments in one line
authorSven Schnelle <svens@linux.ibm.com>
Sun, 4 Dec 2022 19:55:27 +0000 (20:55 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Mon, 9 Jan 2023 13:34:02 +0000 (14:34 +0100)
fix the following and similar checkpatch warnings:

CHECK: multiple assignments should be avoided
+        tp->cx = tp->saved_cx = 0;

Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/s390/char/con3270.c

index f21103a..9a48514 100644 (file)
@@ -1579,8 +1579,10 @@ static void tty3270_escape_sequence(struct tty3270 *tp, char ch)
                        tp->attributes = tp->saved_attributes;
                        break;
                case 'c':               /* Reset terminal. */
-                       tp->cx = tp->saved_cx = 0;
-                       tp->cy = tp->saved_cy = 0;
+                       tp->cx = 0;
+                       tp->cy = 0;
+                       tp->saved_cx = 0;
+                       tp->saved_cy = 0;
                        tty3270_reset_attributes(&tp->attributes);
                        tty3270_reset_attributes(&tp->saved_attributes);
                        tty3270_erase_display(tp, 2);
@@ -1740,7 +1742,8 @@ static void tty3270_do_write(struct tty3270 *tp, struct tty_struct *tty,
                        break;
                case 0x0c:              /* '\f' -- Form Feed */
                        tty3270_erase_display(tp, 2);
-                       tp->cx = tp->cy = 0;
+                       tp->cx = 0;
+                       tp->cy = 0;
                        break;
                case 0x0d:              /* '\r' -- Carriage Return */
                        tp->cx = 0;
@@ -1883,8 +1886,10 @@ static void tty3270_hangup(struct tty_struct *tty)
        if (!tp)
                return;
        spin_lock_irq(&tp->view.lock);
-       tp->cx = tp->saved_cx = 0;
-       tp->cy = tp->saved_cy = 0;
+       tp->cx = 0;
+       tp->cy = 0;
+       tp->saved_cx = 0;
+       tp->saved_cy = 0;
        tty3270_reset_attributes(&tp->attributes);
        tty3270_reset_attributes(&tp->saved_attributes);
        tty3270_blank_screen(tp);