resolved email-service coverity issues 32/190132/1
authorChakradhar <v.pogiri@samsung.com>
Thu, 27 Sep 2018 08:29:02 +0000 (13:59 +0530)
committerChakradhar <v.pogiri@samsung.com>
Thu, 27 Sep 2018 08:29:02 +0000 (13:59 +0530)
Change-Id: I220a4212f56735572e6fec4f74ec1ddf43849062

email-core/email-core-gmime.c
email-core/email-core-utils.c
email-daemon/email-daemon-event.c

index 4aa9d47..c778881 100755 (executable)
@@ -910,7 +910,7 @@ static void emcore_gmime_eml_parse_foreach_cb(GMimeObject *parent, GMimeObject *
 
                g_mime_message_foreach(message, emcore_gmime_eml_parse_foreach_cb, temp_cnt_info);
 
-               save_status = temp_cnt_info->text.plain_save_status;
+               //save_status = temp_cnt_info->text.plain_save_status;
                save_status = temp_cnt_info->text.html_save_status;
 
                for (ai = temp_cnt_info->file; ai; ai = ai->next) {
index ac20679..2e1f5d6 100755 (executable)
@@ -4315,7 +4315,7 @@ static int emcore_get_next_peak_start_time(emstorage_account_tbl_t *input_accoun
                time_info->tm_mday += day_count; /* The other members of time_info will be interpreted or set by mktime */
 
                time_info->tm_hour = input_account_ref->peak_start_time / 100;
-               time_info->tm_min  = input_account_ref->peak_start_time % 100;
+               //time_info->tm_min  = input_account_ref->peak_start_time % 100;
                time_info->tm_min  = 0;
 
                *output_time = mktime(time_info);
@@ -4397,7 +4397,10 @@ INTERNAL_FUNC int emcore_calc_next_time_to_sync(char *multi_user_name, int input
        time_t result_time = 0;
        int    is_time_in_peak_schedule = 0;
 
-       emstorage_get_account_by_id(multi_user_name, input_account_id, EMAIL_ACC_GET_OPT_DEFAULT, &account, true, &err);
+       if(!emstorage_get_account_by_id(multi_user_name, input_account_id, EMAIL_ACC_GET_OPT_DEFAULT, &account, true, &err)){
+               EM_DEBUG_EXCEPTION("emstorage_get_account_by_id failed [%d]", err);
+               goto FINISH_OFF;
+       }
        if (account == NULL) {
                EM_DEBUG_EXCEPTION("emstorage_get_account_by_id failed [%d]", err);
                goto FINISH_OFF;
index e973dfb..e8b190d 100644 (file)
@@ -1405,7 +1405,9 @@ static int event_handler_EMAIL_EVENT_DOWNLOAD_ATTACHMENT(char *multi_user_name,
 
        if (!emnetwork_check_network_status(&err)) {
                EM_DEBUG_EXCEPTION("emnetwork_check_network_status failed [%d]", err);
-               emcore_notify_network_event(NOTI_DOWNLOAD_ATTACH_FAIL, mail_id, NULL, attachment_no, err);
+               if(!emcore_notify_network_event(NOTI_DOWNLOAD_ATTACH_FAIL, mail_id, NULL, attachment_no, err)){
+                       EM_DEBUG_EXCEPTION("emcore_notify_network_event[NOTI_DOWNLOAD_ATTACH_FAIL] Failed >>>>");
+               }
        } else {
 #ifdef __ATTACHMENT_OPTI__
                if (!emcore_download_attachment_bulk(account_id, mail_id, attachment_no, handle_to_be_published, &err))