scsi: lpfc: fix coverity error of dereference after null check
authorJames Smart <jsmart2021@gmail.com>
Fri, 18 Oct 2019 21:18:23 +0000 (14:18 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Oct 2019 01:02:05 +0000 (21:02 -0400)
Log message conditional upon vport being NULL dereferences vport to
determine log verbose setting.

Changed to use lpfc_print_log which uses phba to determine the active log
verbose setting.

Fixes: 43bfea1bffb6 ("scsi: lpfc: Fix coverity errors on NULL pointer checks")
Link: https://lore.kernel.org/r/20191018211832.7917-8-jsmart2021@gmail.com
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_els.c

index da90c7b..2235a45 100644 (file)
@@ -4292,8 +4292,8 @@ lpfc_cmpl_els_rsp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
        irsp = &rspiocb->iocb;
 
        if (!vport) {
-               lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
-                                "3177 ELS response failed\n");
+               lpfc_printf_log(phba, KERN_ERR, LOG_ELS,
+                               "3177 ELS response failed\n");
                goto out;
        }
        if (cmdiocb->context_un.mbox)