libs: encoder: h264fei: remove unnecessary assert
authorVíctor Manuel Jáquez Leal <vjaquez@igalia.com>
Tue, 17 Dec 2019 16:05:22 +0000 (17:05 +0100)
committerVíctor Manuel Jáquez Leal <vjaquez@igalia.com>
Tue, 17 Dec 2019 17:31:36 +0000 (18:31 +0100)
Issue detected by Coverity

An unsigned value can never be negative, so this test will always
evaluate the same way.

In add_slice_headers: An unsigned value can never be less than 0

gst-libs/gst/vaapi/gstvaapifeienc_h264.c

index ab8642a..333744b 100644 (file)
@@ -864,7 +864,7 @@ add_slice_headers (GstVaapiFeiEncH264 * feienc, GstVaapiEncPicture * picture,
       slice_param->num_ref_idx_l1_active_minus1 = reflist_1_count - 1;
     else
       slice_param->num_ref_idx_l1_active_minus1 = 0;
-    g_assert (slice_param->num_ref_idx_l0_active_minus1 >= 0);
+    g_assert (slice_param->num_ref_idx_l0_active_minus1 == 0);
     g_assert (slice_param->num_ref_idx_l1_active_minus1 == 0);
 
     i_ref = 0;