iommu/mediatek: Fix forever loop in error handling

[ Upstream commit 462e768b55a2331324ff72e74706261134369826 ]

There is a typo so this loop does i++ where i-- was intended.  It will
result in looping until the kernel crashes.

Fixes: 26593928564c ("iommu/mediatek: Add error path for loop of mm_dts_parse")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Link: https://lore.kernel.org/r/Y5C3mTam2nkbaz6o@kili
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index f1547199026cd0d9d9ac14b0ade4447460f98825..dad2f238ffbf2736ddb28761a2c3b9b104e73b43 100644 (file)
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -1130,8 +1130,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m
        return 0;
 
 err_larbdev_put:
-       /* id may be not linear mapping, loop whole the array */
-       for (i = MTK_LARB_NR_MAX - 1; i >= 0; i++) {
+       for (i = MTK_LARB_NR_MAX - 1; i >= 0; i--) {
                if (!data->larb_imu[i].dev)
                        continue;
                put_device(data->larb_imu[i].dev);