usb: core: acpi: Use the sysdev pointer instead of controller device
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Thu, 28 Apr 2022 11:10:55 +0000 (14:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 May 2022 19:57:31 +0000 (21:57 +0200)
The controller device (hcd) does not always have the ACPI
companion assigned to it at all. We can not rely on it when
finding the ACPI companion for the root hub. Instead we need
to use the sysdev pointer.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220428111056.3558-2-heikki.krogerus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/usb-acpi.c

index bb1da35..d4dcaef 100644 (file)
@@ -205,8 +205,11 @@ usb_acpi_find_companion_for_device(struct usb_device *udev)
        struct usb_hub *hub;
 
        if (!udev->parent) {
-               /* root hub is only child (_ADR=0) under its parent, the HC */
-               adev = ACPI_COMPANION(udev->dev.parent);
+               /*
+                * root hub is only child (_ADR=0) under its parent, the HC.
+                * sysdev pointer is the HC as seen from firmware.
+                */
+               adev = ACPI_COMPANION(udev->bus->sysdev);
                return acpi_find_child_device(adev, 0, false);
        }