3C509: rx_bytes should not be increased when alloc_skb failed
authorWang Chen <wangchen@cn.fujitsu.com>
Tue, 20 May 2008 09:13:52 +0000 (17:13 +0800)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 22 May 2008 18:02:46 +0000 (14:02 -0400)
If alloc_skb failed, the recieved packet will be dropped. Do not increase
rx_bytes for dropped packet.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/3c509.c

index e6c545f..fe6d841 100644 (file)
@@ -1063,7 +1063,6 @@ el3_rx(struct net_device *dev)
                        struct sk_buff *skb;
 
                        skb = dev_alloc_skb(pkt_len+5);
-                       dev->stats.rx_bytes += pkt_len;
                        if (el3_debug > 4)
                                printk("Receiving packet size %d status %4.4x.\n",
                                           pkt_len, rx_status);
@@ -1078,6 +1077,7 @@ el3_rx(struct net_device *dev)
                                skb->protocol = eth_type_trans(skb,dev);
                                netif_rx(skb);
                                dev->last_rx = jiffies;
+                               dev->stats.rx_bytes += pkt_len;
                                dev->stats.rx_packets++;
                                continue;
                        }