ppp: Destroy the mutex when cleanup
authorGao Feng <gfree.wind@vip.163.com>
Tue, 31 Oct 2017 10:25:37 +0000 (18:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2017 09:10:28 +0000 (10:10 +0100)
[ Upstream commit f02b2320b27c16b644691267ee3b5c110846f49e ]

The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the
good readbility, it's better to invoke it in exit func when the init
func invokes mutex_init.

Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ppp/ppp_generic.c

index e365866..bf14c51 100644 (file)
@@ -959,6 +959,7 @@ static __net_exit void ppp_exit_net(struct net *net)
        unregister_netdevice_many(&list);
        rtnl_unlock();
 
+       mutex_destroy(&pn->all_ppp_mutex);
        idr_destroy(&pn->units_idr);
 }