rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
authorColin Ian King <colin.king@canonical.com>
Fri, 15 Oct 2021 15:21:13 +0000 (16:21 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 18 Oct 2021 12:31:24 +0000 (15:31 +0300)
The function rtw89_mac_enable_bb_rf is a void return type, so there is
no return error code to ret, so the following check for an error in ret
is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211015152113.33179-1-colin.king@canonical.com
drivers/net/wireless/realtek/rtw89/mac.c

index 0171a5a..69384c4 100644 (file)
@@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
                goto fail;
 
        rtw89_mac_enable_bb_rf(rtwdev);
-       if (ret)
-               goto fail;
 
        ret = rtw89_mac_sys_init(rtwdev);
        if (ret)