greybus: module: fix double freeing of module structure

The module will be released by gb_module_release() once all references
for the module are dropped. And so there is no need to free it in the
error path specially.

Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/module.c b/drivers/staging/greybus/module.c
index d7706544f3bea56b5ed9da8d8304b2061a72c589..43e8bab91cafe9329ee86d0120506e6ad6fbcc47 100644 (file)
--- a/drivers/staging/greybus/module.c
+++ b/drivers/staging/greybus/module.c
@@ -151,7 +151,6 @@ struct gb_module *gb_module_create(struct device *parent, u8 module_id)
                pr_err("failed to add module device for id 0x%02hhx\n",
                        module_id);
                put_device(&module->dev);
-               kfree(module);
                return NULL;
        }