gallivm: zero init the temporary register storage.
authorDave Airlie <airlied@redhat.com>
Thu, 29 Oct 2020 03:06:43 +0000 (13:06 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 29 Oct 2020 19:30:35 +0000 (05:30 +1000)
Due to flow control we can end up with random values in here having
side effects.

This fixes a crash in gtk4-demo.

Fixes: 44a6b0107b37 ("gallivm: add nir->llvm translation (v2)")
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7327>

src/gallium/auxiliary/gallivm/lp_bld_nir.c

index a8988f6..23e5780 100644 (file)
@@ -2215,8 +2215,8 @@ bool lp_build_nir_llvm(
 
    nir_foreach_register(reg, &func->impl->registers) {
       LLVMTypeRef type = get_register_type(bld_base, reg);
-      LLVMValueRef reg_alloc = lp_build_alloca_undef(bld_base->base.gallivm,
-                                                     type, "reg");
+      LLVMValueRef reg_alloc = lp_build_alloca(bld_base->base.gallivm,
+                                               type, "reg");
       _mesa_hash_table_insert(bld_base->regs, reg, reg_alloc);
    }
    nir_index_ssa_defs(func->impl);