pmdomain: imx93-blk-ctrl: correct remove path
authorPeng Fan <peng.fan@nxp.com>
Fri, 1 Nov 2024 10:12:51 +0000 (18:12 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 1 Nov 2024 11:53:16 +0000 (12:53 +0100)
The check condition should be 'i < bc->onecell_data.num_domains', not
'bc->onecell_data.num_domains' which will make the look never finish
and cause kernel panic.

Also disable runtime to address
"imx93-blk-ctrl 4ac10000.system-controller: Unbalanced pm_runtime_enable!"

Fixes: e9aa77d413c9 ("soc: imx: add i.MX93 media blk ctrl driver")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Cc: stable@vger.kernel.org
Message-ID: <20241101101252.1448466-1-peng.fan@oss.nxp.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/imx/imx93-blk-ctrl.c

index 904ffa55b8f4d38472e7bece45e0a1cb4386acaf..b10348ac10f06d703b5d50eea6c58efb15695100 100644 (file)
@@ -313,7 +313,9 @@ static void imx93_blk_ctrl_remove(struct platform_device *pdev)
 
        of_genpd_del_provider(pdev->dev.of_node);
 
-       for (i = 0; bc->onecell_data.num_domains; i++) {
+       pm_runtime_disable(&pdev->dev);
+
+       for (i = 0; i < bc->onecell_data.num_domains; i++) {
                struct imx93_blk_ctrl_domain *domain = &bc->domains[i];
 
                pm_genpd_remove(&domain->genpd);