ASoC: samsung: tm2_wm5110: remove shadowed variable
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 12 Mar 2021 18:02:31 +0000 (12:02 -0600)
committerMark Brown <broonie@kernel.org>
Fri, 12 Mar 2021 20:45:41 +0000 (20:45 +0000)
cppcheck warning:

sound/soc/samsung/tm2_wm5110.c:552:26: style: Local variable 'args'
shadows outer variable [shadowVariable]
  struct of_phandle_args args;
                         ^
sound/soc/samsung/tm2_wm5110.c:504:25: note: Shadowed declaration
 struct of_phandle_args args;
                        ^
sound/soc/samsung/tm2_wm5110.c:552:26: note: Shadow variable
  struct of_phandle_args args;
                         ^
Move the top-level variable to the lower scope where it's needed.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210312180231.2741-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/samsung/tm2_wm5110.c

index 125e07f..84c2c63 100644 (file)
@@ -501,7 +501,6 @@ static int tm2_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct snd_soc_card *card = &tm2_card;
        struct tm2_machine_priv *priv;
-       struct of_phandle_args args;
        struct snd_soc_dai_link *dai_link;
        int num_codecs, ret, i;
 
@@ -585,6 +584,8 @@ static int tm2_probe(struct platform_device *pdev)
        }
 
        if (num_codecs > 1) {
+               struct of_phandle_args args;
+
                /* HDMI DAI link (I2S1) */
                i = card->num_links - 1;